Core: Include CRC values in DV deserialization error message - #17393
Open
uros-b wants to merge 3 commits into
Open
Core: Include CRC values in DV deserialization error message#17393uros-b wants to merge 3 commits into
uros-b wants to merge 3 commits into
Conversation
uros-b
commented
Jul 28, 2026
uros-b
left a comment
uros-b
left a comment
Member
Author
There was a problem hiding this comment.
@aokolnychyi please review
uros-b
force-pushed
the
core-improve-dv-crc-error-message
branch
from
July 29, 2026 22:35
ad6c308 to
7a881ff
Compare
nastra
reviewed
Jul 30, 2026
Member
Author
|
cc @huaxingao to PTAL ^^ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a deletion vector fails CRC validation, the error message was a static "Invalid CRC". This includes the actual and expected CRC values to make the failure actionable, matching the sibling validation messages in the same class (
Invalid magic number/cardinality/bitmap data length: %s, expected %s).